Add support for ssl peer fingerprint #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bazsi
force-pushed
the
add-support-for-ssl-peer-fingerprint
branch
from
39e4122
to
5de78b1
Compare
MrAnno
reviewed
Jun 7, 2024
Signed-off-by: Balazs Scheidler <[email protected]>
…erprint
If trusted-keys() is used, the certificate fingerprint is added added
to ${.tls.x509_fp} with the same algorithm that was used to validate
trusted-keys, which is SHA1 at the moment (unfortunately, but that's
a separate PR.
Signed-off-by: Balazs Scheidler <[email protected]>
bazsi
force-pushed
the
add-support-for-ssl-peer-fingerprint
branch
2 times, most recently
from
bcbee05
to
fc94e9f
Compare
Signed-off-by: Balazs Scheidler <[email protected]>
|
I've dropped the change in trusted-keys() validation, as we agreed with @MrAnno that it should be introduced with a new option (trusted-fingerprints() or something like that). By dropping this patch, this PR became very simple, if there's trusted-keys() based validation in a config, the key fingerprint is saved into ${.tls.x509_fp} along with the CA and similar parameters. With that this is mergable. |
MrAnno
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves syslog-ng/syslog-ng#4978