Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clang-tidy github action #270

Closed

Conversation

Yaraslaut
Copy link

@Yaraslaut Yaraslaut commented Jul 1, 2024

PR adds clang-tidy check into github action when building with clang compiler
Closes #37

@Yaraslaut Yaraslaut force-pushed the improvement/actions_clang_tidy branch from 666dba6 to 10968e1 Compare July 1, 2024 15:57
@hughcars
Copy link
Collaborator

Hi @Yaraslaut thank you for the pr. We've considered adding in clang-tidy in the past, #37 #14 as it would be good to have that extra level of linting. However, we found that the number of false positives we were getting was pretty enormous so decided to abandon the project (at least for the time being). If you were interested in taking a look at deciding on what the appropriate settings we'd want for Palace (and probably the corresponding fixes 😅), we'd be very interested in a contribution.

@Yaraslaut
Copy link
Author

Hi @Yaraslaut thank you for the pr. We've considered adding in clang-tidy in the past, #37 #14 as it would be good to have that extra level of linting. However, we found that the number of false positives we were getting was pretty enormous so decided to abandon the project (at least for the time being). If you were interested in taking a look at deciding on what the appropriate settings we'd want for Palace (and probably the corresponding fixes 😅), we'd be very interested in a contribution.

Hi @hughcars, thanks for the update, I can fix some of the checks and update clang-tidy file to ignore noisy one, i will try to include only easy fixes, and can increase number of checks in future PRs, if i will attempt to fix every check it will be too huge of a change for a one go

@Yaraslaut Yaraslaut force-pushed the improvement/actions_clang_tidy branch from 396ec78 to 6de0e0b Compare July 19, 2024 06:40
@Yaraslaut Yaraslaut force-pushed the improvement/actions_clang_tidy branch from 6de0e0b to b96cd00 Compare July 19, 2024 06:58
@Yaraslaut Yaraslaut force-pushed the improvement/actions_clang_tidy branch from 6567b13 to e5266b7 Compare July 19, 2024 12:59
@Yaraslaut Yaraslaut closed this by deleting the head repository Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run clang-tidy in CI
2 participants