Clang tidy fixes dev #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughcars
force-pushed
the
clang-tidy-fixes-dev
branch
4 times, most recently
from
1043ebc
to
015399d
Compare
hughcars
force-pushed
the
clang-tidy-fixes-dev
branch
from
015399d
to
967a8a5
Compare
|
Closing this based on offline discussion. Decided that most of this is noise and clang-tidy won't be getting raised to CI level, so not necessary to fix. |
|
Changes have been relocated to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Fixes to get
clang-tidybuilds to pass again. Was working on another branch and need a passing ground zero to work from. Various miscellaneous changes, most interesting being adding theNOLINTsuppression patch to mfem. Have sent a PR upstreaming it.Issue #, if available:
#13