-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clang-tidy github action #270
Conversation
666dba6
to
10968e1
Compare
Hi @Yaraslaut thank you for the pr. We've considered adding in clang-tidy in the past, #37 #14 as it would be good to have that extra level of linting. However, we found that the number of false positives we were getting was pretty enormous so decided to abandon the project (at least for the time being). If you were interested in taking a look at deciding on what the appropriate settings we'd want for Palace (and probably the corresponding fixes 😅), we'd be very interested in a contribution. |
Hi @hughcars, thanks for the update, I can fix some of the checks and update clang-tidy file to ignore noisy one, i will try to include only easy fixes, and can increase number of checks in future PRs, if i will attempt to fix every check it will be too huge of a change for a one go |
396ec78
to
6de0e0b
Compare
6de0e0b
to
b96cd00
Compare
6567b13
to
e5266b7
Compare
PR adds clang-tidy check into github action when building with clang compiler
Closes #37