Use top-level file in write benchmark #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alessandro Passaro <[email protected]>
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
jamesbornholt
approved these changes
Nov 18, 2023
There was a problem hiding this comment.
From the log, it looks like this is implicit directories working as intended: once the last object in the directory was unlinked, the directory went away, but fio doesn't try to recreate the entire directory hierarchy, just the file. I assume it worked before #584 because the local directory's dentry was cached forever by the kernel, so it never needed to re-lookup the directory to do the creat.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The write throughput benchmarks were failing when running the second iteration because fio would not re-create the nested path for the benchmark file. This appears to have started since #584. Further investigation required to determine if there is an issue with Mountpoint.
This change only unblocks the benchmarks by configuring fio to use a file at the top-level in the mount directory, which was likely the intention in the first place (fio's
--filenamepath is relative to--directory).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).