Change local file/directory expiry TTL from NEVER_EXPIRE to 100ms #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauraank
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
requested changes
Oct 30, 2023
sauraank
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
sauraank
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
changed the title
dannycjones
reviewed
Oct 30, 2023
|
The integration tests are failing and I suspect it is related to this change, can you investigate @sauraank? For example, |
sauraank
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
sauraank
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
sauraank
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
sauraank
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
sauraank
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
sauraank
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
sauraank
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
sauraank
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
sauraank
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
reviewed
Nov 8, 2023
| None, | ||
| None, | ||
| None, | ||
| self.inner.cache_config.file_ttl, |
There was a problem hiding this comment.
Maybe this will never happen since I'm guessing applications almost always open the file immediately after performing a mknod, but an open 100ms after the mknod will now go to S3 even though we know we'll always choose the local node over a remote one.
Not worried right now, but just noting this observation.
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
force-pushed
the
file_validity
branch
from
9f16905 to
c5730d3
Compare
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
reviewed
Nov 14, 2023
There was a problem hiding this comment.
We should update the release notes in this PR too as we're fixing #577.
Signed-off-by: Ankit Saurabh <[email protected]>
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
requested changes
Nov 14, 2023
mountpoint-s3/src/inode.rs
Outdated
| Ok(LookedUp { | ||
| inode: existing_inode, | ||
| inode: existing_inode.clone(), |
There was a problem hiding this comment.
We should not need to clone here:
Suggested change
| inode: existing_inode.clone(), | |
| inode: existing_inode, |
Signed-off-by: Ankit Saurabh <[email protected]>
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This change allows mountpoint to rewrite to the same file which was deleted remotely using other methods like console/aws cli. Earlier, Due to large validity of files and directories, the inodes corresponding were remembered by kernel forever. So, even deleting remotely did not make kernel call
lookupagain for those files.Relevant issues:
#577
Does this change impact existing behavior?
No.
There is no breaking change.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).