Skip to content

Commit

Permalink
Improved S3 progress callback (#666)
Browse files Browse the repository at this point in the history
Update to latest submodules. This gets us the improved S3 progress callbacks, which now fire for every meta-request type, and no longer overlap. See: awslabs/aws-c-s3#344

```
aws-c-auth         v0.7.2 -> v0.7.3
aws-c-cal          v0.6.1 -> v0.6.2
aws-c-common       v0.9.0 -> v0.9.1
aws-c-event-stream v0.3.1 -> v0.3.2
aws-c-http         v0.7.11 -> v0.7.12
aws-c-io           v0.13.31 -> v0.13.32
aws-c-mqtt         v0.9.3 -> v0.9.5
aws-c-s3           v0.3.14 -> v0.3.16
aws-lc             v1.13.0 -> v1.14.0
s2n                v1.3.48 -> v1.3.50
```
  • Loading branch information
graebm authored Aug 26, 2023
1 parent 2418b06 commit 1271b25
Show file tree
Hide file tree
Showing 11 changed files with 15 additions and 12 deletions.
2 changes: 1 addition & 1 deletion crt/aws-c-auth
2 changes: 1 addition & 1 deletion crt/aws-c-event-stream
2 changes: 1 addition & 1 deletion crt/aws-c-http
2 changes: 1 addition & 1 deletion crt/aws-lc
2 changes: 1 addition & 1 deletion crt/s2n
Submodule s2n updated from 65e74c to baf094
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,11 @@ default void onFinished(S3FinishedResponseContext context) {

/**
* Invoked to report progress of the meta request execution.
* Currently, the progress callback is invoked only for the CopyObject and PutObject meta request type.
* TODO: support this callback for all types of meta requests
* The meaning of "progress" depends on the {@link S3MetaRequestOptions.MetaRequestType}.
* For PUT_OBJECT, it refers to bytes uploaded.
* For COPY_OBJECT, it refers to bytes copied.
* For GET_OBJECT, it refers to bytes downloaded.
* For anything else, it refers to response body bytes received.
* @param progress information about the progress of the meta request execution
*/
default void onProgress(final S3MetaRequestProgress progress) {
Expand Down

0 comments on commit 1271b25

Please sign in to comment.