-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progress callbacks fire for all meta-request types #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #344 +/- ##
==========================================
- Coverage 89.52% 89.51% -0.02%
==========================================
Files 17 17
Lines 4897 4929 +32
==========================================
+ Hits 4384 4412 +28
- Misses 513 517 +4
|
DmitriyMusatkin
approved these changes
Aug 24, 2023
waahm7
reviewed
Aug 24, 2023
…th. We've had errors around this in the past.
…sts, so it's unnecessary.
TingDaoK
reviewed
Aug 25, 2023
graebm
added a commit
to awslabs/aws-crt-java
that referenced
this pull request
Aug 26, 2023
Update to latest submodules. This gets us the improved S3 progress callbacks, which now fire for every meta-request type, and no longer overlap. See: awslabs/aws-c-s3#344 ``` aws-c-auth v0.7.2 -> v0.7.3 aws-c-cal v0.6.1 -> v0.6.2 aws-c-common v0.9.0 -> v0.9.1 aws-c-event-stream v0.3.1 -> v0.3.2 aws-c-http v0.7.11 -> v0.7.12 aws-c-io v0.13.31 -> v0.13.32 aws-c-mqtt v0.9.3 -> v0.9.5 aws-c-s3 v0.3.14 -> v0.3.16 aws-lc v1.13.0 -> v1.14.0 s2n v1.3.48 -> v1.3.50 ```
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.