aws_tls_connection_options_copy comment update following #eaa583a or #475 #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbSteveK
approved these changes
Apr 7, 2022
SergeyRyabinin
force-pushed
the
srComment
branch
from
7da0d11 to
40f3d57
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #482 +/- ##
=======================================
Coverage 80.11% 80.11%
=======================================
Files 28 28
Lines 5964 5964
=======================================
Hits 4778 4778
Misses 1186 1186 ☔ View full report in Codecov by Sentry. |
alfred2g
pushed a commit
that referenced
this pull request
May 21, 2024
…475 (#482) Authored-by: Sergey Ryabinin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Before #475 ,
aws_tls_connection_options_copybehaved just like memcpy and did not require initializedto/dst.After #475, it first performs some actions on values in
to, effectively enforcingtoto be initialized.Description of changes:
Update comment.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.