Fix memory leak in aws_tls_connection_options_copy #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bretambrose
approved these changes
Feb 9, 2022
xiazhvera
changed the title
SergeyRyabinin
pushed a commit
that referenced
this pull request
Apr 7, 2022
SergeyRyabinin
pushed a commit
that referenced
this pull request
Apr 7, 2022
jmklix
pushed a commit
that referenced
this pull request
Apr 22, 2024
…475 (#482) Authored-by: Sergey Ryabinin <[email protected]>
alfred2g
pushed a commit
that referenced
this pull request
May 21, 2024
…475 (#482) Authored-by: Sergey Ryabinin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Memory leak in Connection function is reported at aws/aws-iot-device-sdk-cpp-v2#215
We tracked down the issue and find it is related to aws_tls_connection_options_copy.
Description of changes:
Release the tls option data before copy happens in aws_tls_connection_options_copy.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.