[Issue-35] remove log configuration and add example for debug #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eploy profile enabled
…ect with different java versions
… logs information
…config AT-1469 remove log configuration and add example for debug
…pg-only-if-deploy-flag-presented
…ndency AT-1468 update dependency and spotbugs
…ly-if-deploy-flag-presented AT-1467 add GPG documentation and modify plugin to sign jar
rajeiyer
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Our code has a static block that creates a sl4j bridge and set up a log level for the whole application.
That behavior overrides the default application configuration.
With the fix redundant code blocks has been removed and documentation on how to trace using the different application has been added to README.md
Description
The driver overrides LOG level for the application. (Application print logs that are available only for trace/debug purposes)
Related Issue
Issue-35
Tests performed/created
Unit tests:
All existing Unit tests passed
Manual verification:
Build the project with the command
mvn clean installUse the signed jar in
DBeaverCreate a timestream connection
Open Logs and verify that timestream driver logs present
Build the project with the command
mvn clean installUse the signed jar in `new java project as a dependency
Create a timestream connection
Open Logs and verify that timestream driver logs present
Change the Log level to debug
Verify that additional driver logs are added to the log file
Additional Reviewers
@alexey-temnikov