Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect logging #35

Closed
kassak opened this issue Jan 30, 2023 · 3 comments
Closed

Incorrect logging #35

kassak opened this issue Jan 30, 2023 · 3 comments

Comments

@kassak
Copy link

kassak commented Jan 30, 2023

Driver is a library and library should not configure logging for the whole application, at least by default

Apart from broken logging for the whole application it can end up like this https://youtrack.jetbrains.com/issue/DBE-17279

@MarcelloModica
Copy link

I'm facing the same issue in JETBRAINS datagrip.
https://youtrack.jetbrains.com/issue/DBE-17253/AWS-Timestream-support-seems-to-have-broken-in-a-recent-release
https://youtrack.jetbrains.com/issue/DBE-17279

Martin Macák commented 1 Feb 2023 11:29
I recompiled the 2.0.0 driver without SLF4J hooks and it seems to work

How can i apply same fix?

@ketronkowski
Copy link

@MarcelloModica
Comment out the lines

    SLF4JBridgeHandler.removeHandlersForRootLogger();
    SLF4JBridgeHandler.install();

in jdbc/src/main/java/software/amazon/timestream/jdbc/TimestreamDriver.java and jdbc/src/main/java/software/amazon/timestream/jdbc/TimestreamDataSource.java and then build a driver with maven clean package. Those changes also provide a working version of the driver for me.

@dkovalenkoI
Copy link
Contributor

@kassak , The pull request has been created to address the reported issue.

Thank you for your patience and valuable feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants