Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Lombok #192

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Remove Lombok #192

merged 1 commit into from
Mar 23, 2023

Conversation

vpavic
Copy link
Contributor

@vpavic vpavic commented Mar 22, 2023

Issue #, if available:
See #189.

Description of changes:
This removes Lombok from the project.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@ziyanli-amazon ziyanli-amazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Thanks for reducing the overheads for us. minor comment made

@vpavic
Copy link
Contributor Author

vpavic commented Mar 23, 2023

Thanks for the feedback, I wasn't aware that v1 branch didn't use Lombok.

I've aligned implementations of #toString, #hashCode and #equals as well as javadoc with v1 branch.

Copy link
Contributor

@ziyanli-amazon ziyanli-amazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks

@ziyanli-amazon ziyanli-amazon merged commit d98f1b7 into awslabs:master Mar 23, 2023
@vpavic vpavic deleted the remove-lombok branch March 23, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants