Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid pulling in Lombok as transitive dependency #189

Closed
vpavic opened this issue Mar 14, 2023 · 3 comments
Closed

Avoid pulling in Lombok as transitive dependency #189

vpavic opened this issue Mar 14, 2023 · 3 comments

Comments

@vpavic
Copy link
Contributor

vpavic commented Mar 14, 2023

At present, this library pulls in Lombok as transitive dependency, which really shouldn't be the case as it is an annotation processor. See Maven setup on Lombok website.

Additionally, since Lombok doesn't appear to be heavily used (only in two classes) in the project, I'd suggest removing it altogether in order to make the debugging easier. If you agree with this proposal, I'd gladly contribute a PR.
@ziyanli-amazon
Copy link
Contributor

Sounds good @vpavic . Feel free to submit a PR and I will review it right away.

@vpavic vpavic mentioned this issue Mar 22, 2023
Merged
@vpavic
Copy link
Contributor Author

vpavic commented Mar 22, 2023

Thanks for the feedback @ziyanli-amazon, I've opened #192.

@vpavic
Copy link
Contributor Author

vpavic commented Mar 23, 2023

This is now basically a duplicate of #192 that has just been merged.

@vpavic vpavic closed this as not planned Won't fix, can't repro, duplicate, stale Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vpavic @ziyanli-amazon