fix: Defining CORS when ApiKeyRequired is true results in an OPTIONS method that requires an API key #2981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoffa
reviewed
Mar 2, 2023
GavinZZ
reviewed
Mar 2, 2023
hoffa
reviewed
Mar 2, 2023
Easier to read Co-authored-by: Christoffer Rehn <[email protected]>
aaythapa
previously approved these changes
Mar 2, 2023
ssenchenko
approved these changes
Mar 3, 2023
hoffa
reviewed
Mar 3, 2023
hoffa
reviewed
Mar 3, 2023
hoffa
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available
#1786
Description of changes
Created a property of AWS::Serverless::Api::Auth called AddApiKeyRequiredToCorsPreflight. When set to false does not apply ApiKeyRequired to Cors Preflight requests. By Default set to true.
Description of how you validated changes
Transformed a template that had the issue where ApiKeyRequired was being applied to CorsPreflight requests. Set AddApiKeyRequired to Cors Preflight to false. Checked if the transformed template required an ApiKey in the Cors section.
Checklist
Examples?
Please reach out in the comments if you want to add an example. Examples will be
added to
sam initthrough aws/aws-sam-cli-app-templates.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.