Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'ApiKeyRequiredToCorsPreflight' #2350

Closed
chillbirdo opened this issue Mar 15, 2022 · 2 comments
Closed

Add 'ApiKeyRequiredToCorsPreflight' #2350

chillbirdo opened this issue Mar 15, 2022 · 2 comments

Comments

@chillbirdo
Copy link

Describe your idea/feature/enhancement

The flag AddDefaultAuthorizerToCorsPreflight skips Authorizers for preflight methods, however, it does not skip the requirement of an API-Key (as far as the UsagePlan is linked to a key). Browsers do never add the X-API-Key Header to the preflight request.

At the moment I have no idea how to omit ApiKey requirement for the preflight requests other than switching them off in the console after each deploy. Pls give me a hint if it can be stated in the template somehow. Thanks.

Proposal

Either generally disable ApiKey Requirement for Preflight requests, or add a flag similar to AddDefaultAuthorizerToCorsPreflight, named something like ApiKeyRequiredToCorsPreflight.

Things to consider:

  1. Will this require any updates to the SAM Spec
    Yes

Additional Details

@CoshUS
Copy link
Contributor

CoshUS commented Mar 15, 2022

SAM issue. Transferring to SAM repo.

@ConnorRobertson
Copy link

ConnorRobertson commented May 1, 2023

#1786 Issue was fixed here. You can add the property AddApiKeyRequiredToCorsPreflight to the Auth: section of the Api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants