Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added langchain-aws package. #382

Merged
merged 2 commits into from
May 31, 2024
Merged

Added langchain-aws package. #382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89e875f
Add langchain-aws, new minor version 1.9.0
andrii-i May 22, 2024
41bac1a
Add newline at EOF to added files
andrii-i May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build_artifacts/v1/v1.9/v1.9.0/cpu.additional_packages_env.in
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
conda-forge::langchain-aws[version='>=0.1.1,<0.2.0']
1 change: 1 addition & 0 deletions build_artifacts/v1/v1.9/v1.9.0/gpu.additional_packages_env.in
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
conda-forge::langchain-aws[version='>=0.1.1,<0.2.0']
13 changes: 13 additions & 0 deletions test/test_artifacts/v1/langchain-aws.test.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
ARG SAGEMAKER_DISTRIBUTION_IMAGE
FROM $SAGEMAKER_DISTRIBUTION_IMAGE

ARG MAMBA_DOCKERFILE_ACTIVATE=1

CMD ["python", "-c", "import langchain_aws"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add more tests

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for giving this PR a look @balajisankar15. Is this blocking / could we add more tests in the follow-up PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@balajisankar15
We can add more tests around importing other sub-modules to test their importability. Anything other than that requires an elaborate setup with boto3 credentials and service endpoint infrastructure (bedrock, kendra, vectorstores etc.) to test each of these components, which we don't plan to do for this library.
We will update the PR with these and open for a review. Thanks.

CMD ["python", "-c", "from langchain_aws import BedrockLLM"]
CMD ["python", "-c", "from langchain_aws import ChatBedrock"]
CMD ["python", "-c", "from langchain_aws import SagemakerEndpoint"]
CMD ["python", "-c", "from langchain_aws import AmazonKendraRetriever"]
CMD ["python", "-c", "from langchain_aws import AmazonKnowledgeBasesRetriever"]
CMD ["python", "-c", "from langchain_aws import NeptuneAnalyticsGraph"]
CMD ["python", "-c", "from langchain_aws import NeptuneGraph"]
2 changes: 2 additions & 0 deletions test/test_dockerfile_based_harness.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
("amazon-sagemaker-sql-magic.test.Dockerfile", ["amazon-sagemaker-sql-magic"]),
("amazon_sagemaker_sql_editor.test.Dockerfile", ["amazon_sagemaker_sql_editor"]),
("serve.test.Dockerfile", ["serve-langchain"]),
("langchain-aws.test.Dockerfile", ["langchain-aws"]),
],
)
def test_dockerfiles_for_cpu(
Expand Down Expand Up @@ -81,6 +82,7 @@ def test_dockerfiles_for_cpu(
("amazon-sagemaker-sql-magic.test.Dockerfile", ["amazon-sagemaker-sql-magic"]),
("amazon_sagemaker_sql_editor.test.Dockerfile", ["amazon_sagemaker_sql_editor"]),
("serve.test.Dockerfile", ["serve-langchain"]),
("langchain-aws.test.Dockerfile", ["langchain-aws"]),
],
)
def test_dockerfiles_for_gpu(
Expand Down