-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added langchain-aws package. #382
Conversation
I built sagemaker-distribution based on this PR with aws-langchain included and ran a newly-added test cases with Note irregularities with |
|
||
ARG MAMBA_DOCKERFILE_ACTIVATE=1 | ||
|
||
CMD ["python", "-c", "import langchain_aws"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add more tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for giving this PR a look @balajisankar15. Is this blocking / could we add more tests in the follow-up PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@balajisankar15
We can add more tests around importing other sub-modules to test their importability. Anything other than that requires an elaborate setup with boto3 credentials and service endpoint infrastructure (bedrock, kendra, vectorstores etc.) to test each of these components, which we don't plan to do for this library.
We will update the PR with these and open for a review. Thanks.
@balajisankar15 |
b6ed925
to
89e875f
Compare
@balajisankar15 @claytonparnell |
@claytonparnell @balajisankar15 |
Description
Adds langchain-aws package.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.