-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ossl3 legacy provider mem leak #4033
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Pep is complaining about my aligned formatting. I'm of half a mind to have a "you don't get to add a formater to CI unless I can easily run it locally" rule.
lrstewart
approved these changes
Jun 5, 2023
Co-authored-by: Lindsay Stewart <[email protected]>
The successful s2nGeneralBatch with openssl3 can be found in this CI run |
dougch
approved these changes
Jun 5, 2023
jmayclin
added a commit
to jmayclin/s2n-tls
that referenced
this pull request
Jun 13, 2023
This reverts commit 382847c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
#4000
Description of changes:
s2n currently leaks memory when used with ossl3. This was originally discovered when I was futzing about with an attempt at cmake support for asan. Turns out it wasn't a false positive. Valgrind also reported the memory leak, which can be seen here
We have a different codepath involving loading a legacy provider to get
rc4
support when using ossl3. It looks like that is leaking memory. @lrstewart Had a previous solution for rc4 support that involved just disabling rc4 support for ossl3, which is fine since it's use is explicitly banned by RFC 7465This PR pulls in
lrstewarts
commits, and adds some integration test configuration that was needed to make them pass CI. It also adds CI jobs for openssl 3.Testing:
I was able to test locally to confirm that the memory leak was no longer occuring in locally run ASAN jobs. I'll also manually add the new CI jobs to the CI for this PR.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.