bindings: do not enable OCSP when calling trust_location() #4016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goatgoose
reviewed
May 23, 2023
WesleyRosenblum
added
the
do_not_merge
WesleyRosenblum
changed the title
goatgoose
reviewed
Jun 19, 2023
goatgoose
reviewed
Jun 20, 2023
WesleyRosenblum
removed
the
do_not_merge
goatgoose
approved these changes
Jun 21, 2023
maddeleine
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
resolves #3880
Description of changes:
#3830 points out that OCSP requests are auto-enabled on a client when
s2n_config_set_verification_ca_location()is called. Since the Rust bindings equivalenttrust_location()calls this function, it has the same behavior. Since this behavior is confusing and generally not desired, this PR changes the Rust bindings to not auto-enable OCSP whentrust_location()is called.Testing:
Added unit tests and a
HasExtensionClientHelloHandlerthat verifies that a particular extension is present or notBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.