Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust bindings : Support for disabling validation of stapled oscp response #3880

Closed
mathpal opened this issue Mar 14, 2023 · 0 comments · Fixed by #4016
Closed

rust bindings : Support for disabling validation of stapled oscp response #3880

mathpal opened this issue Mar 14, 2023 · 0 comments · Fixed by #4016

Comments

@mathpal
Copy link
Contributor

mathpal commented Mar 14, 2023

Problem:

In the rust bindings, s2n_config_set_check_stapled_ocsp_response is not available, and as a result if server returns ocsp response, then the client would end up validating it, even if it wasn't requested.

Solution:

in impl Config

    pub fn check_stapled_ocsp_response(&mut self, enabled : bool) -> Result<&mut Self, Error> {
        unsafe {
            s2n_config_set_check_stapled_ocsp_response(self.as_mut_ptr(), enabled as u8).into_result()
        }?;
        Ok(self)
    }
  • Does this change what S2N sends over the wire? No
  • Does this change any public APIs? Exposes a new api to Config rust binding.
  • Which versions of TLS will this impact? all

Requirements / Acceptance Criteria:

Checking for ocsp response can be completely turned off at config level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants