Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: grant more permissions to the qns release workflow #2372

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

dougch
Copy link
Contributor

@dougch dougch commented Nov 7, 2024

Resolved issues:

none

Description of changes:

In #2352, we switched to short term credentials for actions use with AWS. This added a permissions stanza to the workflow, but missed a permission needed to publish docker to GitHub container registry.

Call-outs:

Authentication is succeeding, but permissions are insufficient to publish, e.g. https://github.com/aws/s2n-quic/actions/runs/11724796171/job/32659577102

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@camshaft camshaft enabled auto-merge (squash) November 7, 2024 23:22
@camshaft camshaft merged commit 799921c into main Nov 7, 2024
130 checks passed
@camshaft camshaft deleted the qns_perms branch November 7, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants