Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update qns actions for OIDC #2352

Merged
merged 5 commits into from
Oct 17, 2024
Merged

chore: update qns actions for OIDC #2352

merged 5 commits into from
Oct 17, 2024

Conversation

dougch
Copy link
Contributor

@dougch dougch commented Oct 17, 2024

Description of changes:

Rework the qns and release actions to use short term credentials.

Call-outs:

There are now separate roles for S3 access vs Public ECR.

Testing:

Is this a refactor change? Relying on CI

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dougch dougch marked this pull request as ready for review October 17, 2024 22:24
camshaft
camshaft previously approved these changes Oct 17, 2024
.github/workflows/qns.yml Outdated Show resolved Hide resolved
@dougch dougch enabled auto-merge (squash) October 17, 2024 23:04
@dougch dougch merged commit a1f4fc0 into main Oct 17, 2024
130 checks passed
@dougch dougch deleted the oidc_ecr branch October 17, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants