-
Notifications
You must be signed in to change notification settings - Fork 951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: Fixed a few bugs with running integration tests in the integration environment #2184
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,3 +46,8 @@ RUN aws --version | |
# Install eksctl | ||
RUN curl --silent --location "https://github.com/weaveworks/eksctl/releases/download/v0.105.0/eksctl_$(uname -s)_amd64.tar.gz" | tar xz -C /tmp | ||
RUN mv /tmp/eksctl /usr/local/bin | ||
|
||
# Install toolchain | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. seems like you're just caching the modules not installing the "toolchain"? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good point. I was originally going to install the toolchain, but it took foreverrrrr |
||
RUN git clone https://github.com/aws/karpenter.git /karpenter | ||
WORKDIR /karpenter | ||
RUN GOPRIVATE=* go mod tidy | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You shouldn't set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this using flag? It looks like this will only ever get the env variable since you never call flag.Parse. Might as well just use:
or directly in
DiscoverClusterName()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test library calls flags.Parse() for us =/. I can't call it again without creating problem. I like your solution though.