Test: Fixed a few bugs with running integration tests in the integration environment #2184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
ellistarn
force-pushed
the
tolerations
branch
3 times, most recently
from
ef8c196
to
f73cf83
Compare
…do not use latest yaml (yet)
ellistarn
changed the title
bwagner5
reviewed
Jul 26, 2022
test/pkg/environment/environment.go
Outdated
| @@ -25,7 +26,7 @@ import ( | |||
| "github.com/aws/karpenter/pkg/utils/project" | |||
| ) | |||
|
|
|||
| var clusterNameFlag = *flag.String("cluster-name", env.WithDefaultString("CLUSTER_NAME", ""), "Cluster name enables discovery of the testing environment") | |||
| var clusterNameFlag = flag.String("cluster-name", env.WithDefaultString("CLUSTER_NAME", ""), "Cluster name enables discovery of the testing environment") | |||
There was a problem hiding this comment.
Why is this using flag? It looks like this will only ever get the env variable since you never call flag.Parse. Might as well just use:
Suggested change
| var clusterNameFlag = flag.String("cluster-name", env.WithDefaultString("CLUSTER_NAME", ""), "Cluster name enables discovery of the testing environment") | |
| var clusterName = env.WithDefaultString("CLUSTER_NAME", "") |
or directly in DiscoverClusterName()
There was a problem hiding this comment.
The test library calls flags.Parse() for us =/. I can't call it again without creating problem. I like your solution though.
test/tools/Dockerfile
Outdated
| @@ -46,3 +46,8 @@ RUN aws --version | |||
| # Install eksctl | |||
| RUN curl --silent --location "https://github.com/weaveworks/eksctl/releases/download/v0.105.0/eksctl_$(uname -s)_amd64.tar.gz" | tar xz -C /tmp | |||
| RUN mv /tmp/eksctl /usr/local/bin | |||
|
|
|||
| # Install toolchain | |||
There was a problem hiding this comment.
seems like you're just caching the modules not installing the "toolchain"?
There was a problem hiding this comment.
Good point. I was originally going to install the toolchain, but it took foreverrrrr
test/tools/Dockerfile
Outdated
| # Install toolchain | ||
| RUN git clone https://github.com/aws/karpenter.git /karpenter | ||
| WORKDIR /karpenter | ||
| RUN GOPRIVATE=* go mod tidy |
There was a problem hiding this comment.
You shouldn't set GOPRIVATE=* since this causes go to skip checksum verifications... Do you just want the proxy off or is there more you're trying to do here?
ellistarn
added a commit
to ellistarn/karpenter-provider-aws
that referenced
this pull request
Jul 26, 2022
…ion environment (aws#2184) * Test: Add explicit tolerations in test setup since snapshot releases do not use latest yaml (yet) * Restored clustername discovery * PR Comments
ellistarn
added a commit
to ellistarn/karpenter-provider-aws
that referenced
this pull request
Jul 26, 2022
…ion environment (aws#2184) * Test: Add explicit tolerations in test setup since snapshot releases do not use latest yaml (yet) * Restored clustername discovery * PR Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
How was this change tested?
Does this change impact docs?
Release Note
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.