-
Notifications
You must be signed in to change notification settings - Fork 951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: Fixed a few bugs with running integration tests in the integration environment #2184
Conversation
✅ Deploy Preview for karpenter-docs-prod canceled.
|
ef8c196
to
f73cf83
Compare
…do not use latest yaml (yet)
test/pkg/environment/environment.go
Outdated
@@ -25,7 +26,7 @@ import ( | |||
"github.com/aws/karpenter/pkg/utils/project" | |||
) | |||
|
|||
var clusterNameFlag = *flag.String("cluster-name", env.WithDefaultString("CLUSTER_NAME", ""), "Cluster name enables discovery of the testing environment") | |||
var clusterNameFlag = flag.String("cluster-name", env.WithDefaultString("CLUSTER_NAME", ""), "Cluster name enables discovery of the testing environment") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this using flag? It looks like this will only ever get the env variable since you never call flag.Parse. Might as well just use:
var clusterNameFlag = flag.String("cluster-name", env.WithDefaultString("CLUSTER_NAME", ""), "Cluster name enables discovery of the testing environment") | |
var clusterName = env.WithDefaultString("CLUSTER_NAME", "") |
or directly in DiscoverClusterName()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test library calls flags.Parse() for us =/. I can't call it again without creating problem. I like your solution though.
test/tools/Dockerfile
Outdated
@@ -46,3 +46,8 @@ RUN aws --version | |||
# Install eksctl | |||
RUN curl --silent --location "https://github.com/weaveworks/eksctl/releases/download/v0.105.0/eksctl_$(uname -s)_amd64.tar.gz" | tar xz -C /tmp | |||
RUN mv /tmp/eksctl /usr/local/bin | |||
|
|||
# Install toolchain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like you're just caching the modules not installing the "toolchain"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I was originally going to install the toolchain, but it took foreverrrrr
test/tools/Dockerfile
Outdated
# Install toolchain | ||
RUN git clone https://github.com/aws/karpenter.git /karpenter | ||
WORKDIR /karpenter | ||
RUN GOPRIVATE=* go mod tidy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't set GOPRIVATE=*
since this causes go to skip checksum verifications... Do you just want the proxy off or is there more you're trying to do here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…ion environment (aws#2184) * Test: Add explicit tolerations in test setup since snapshot releases do not use latest yaml (yet) * Restored clustername discovery * PR Comments
…ion environment (aws#2184) * Test: Add explicit tolerations in test setup since snapshot releases do not use latest yaml (yet) * Restored clustername discovery * PR Comments
Fixes #
Description
How was this change tested?
Does this change impact docs?
Release Note
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.