Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove instance type compression #2121

Merged
merged 1 commit into from
Jul 13, 2022
Merged

fix: remove instance type compression #2121

merged 1 commit into from
Jul 13, 2022

Conversation

bwagner5
Copy link
Contributor

Fixes #

Description

  • Remove unneeded instance type compression that is surprising to use since some fields are removed from the regular ec2.InstanceTypeInfo type.

How was this change tested?

  • make test

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bwagner5 bwagner5 requested a review from a team as a code owner July 13, 2022 18:35
@bwagner5 bwagner5 requested a review from suket22 July 13, 2022 18:35
@netlify
Copy link

netlify bot commented Jul 13, 2022 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 0595d9b
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/62cf108c9945130009491484
😎 Deploy Preview https://deploy-preview-2121--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

tzneal
tzneal approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@tzneal tzneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bwagner5 bwagner5 merged commit 5116513 into aws:main Jul 13, 2022
@bwagner5 bwagner5 deleted the remove-ec2-comp branch July 13, 2022 19:36
This was referenced Jul 13, 2022
Closed
Merged
@suket22 suket22 mentioned this pull request Jul 21, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzneal tzneal tzneal approved these changes

@suket22 suket22 Awaiting requested review from suket22 suket22 is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bwagner5 @tzneal