Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding Custom AMIFamily and validations #2154

Merged
merged 5 commits into from
Jul 21, 2022
Merged

feat: Adding Custom AMIFamily and validations #2154

merged 5 commits into from
Jul 21, 2022

Conversation

suket22
Copy link
Contributor

@suket22 suket22 commented Jul 19, 2022 •
edited
Loading

  • feat: Adding Custom AMIFamily and validations

Description
This adds a new AMIFamily - Custom. When the AMIFamily is Custom -

  • We'll use the UserData that's provided to the awsnodetemplate as is. No merging whatsoever.
  • When we binpack, we'll assume that the default EBS volume is of size 20G, and that the kubeReserved, sysReserved values etc match what the EKS AMI has. This needs to be done better but is outside the scope of this initial PR IMO and has to be solved for all AMI families.

How was this change tested?

  • Unit tests and integ tests

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

feat: Adding Custom AMIFamily and validations

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@suket22 suket22 requested a review from a team as a code owner July 19, 2022 20:13
@suket22 suket22 requested a review from dewjam July 19, 2022 20:13
@netlify
Copy link

netlify bot commented Jul 19, 2022 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit f61bdac
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/62d9a08f83962800093361e9
😎 Deploy Preview https://deploy-preview-2154--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@suket22 suket22 requested a review from bwagner5 July 19, 2022 20:34
bwagner5
bwagner5 reviewed Jul 20, 2022
View reviewed changes
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one minor comment, otherwise LGTM

pkg/cloudprovider/aws/instancetype.go Outdated Show resolved Hide resolved
bwagner5
bwagner5 approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@suket22 suket22 merged commit 20c88c0 into aws:main Jul 21, 2022
@suket22 suket22 deleted the customFamily branch July 21, 2022 19:44
@suket22 suket22 mentioned this pull request Jul 21, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwagner5 bwagner5 bwagner5 approved these changes

@dewjam dewjam Awaiting requested review from dewjam dewjam is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suket22 @bwagner5