Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: documenting defaulting behavior for architecture #2095

Merged
merged 1 commit into from
Jul 9, 2022

Conversation

njtran
Copy link
Contributor

@njtran njtran commented Jul 9, 2022

Description
Adding the following to document defaulting behavior for every version since v0.8.1.

# If not included, the webhook for the AWS Cloud Provider will default to amd64

Architecture defaulting was added here where the release after was v0.8.1.

My formatter seems to also want to remove some extra whitespaces.

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@njtran njtran requested a review from a team as a code owner July 9, 2022 00:13
@njtran njtran requested a review from tzneal July 9, 2022 00:13
@netlify
Copy link

netlify bot commented Jul 9, 2022

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit d0b2171
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/62c8c81e8ffade00089e67f3
😎 Deploy Preview https://deploy-preview-2095--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@tzneal tzneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bwagner5 bwagner5 merged commit 415c50b into aws:main Jul 9, 2022
@njtran njtran deleted the amddocs branch August 9, 2022 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants