test: Expand cluster installation test configs #2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ellistarn
reviewed
Jun 29, 2022
njtran
commented
Jul 5, 2022
| resources: | ||
| cpu: 1k | ||
| provider: | ||
| instanceProfile: KitDP-$(params.test-cluster-name) |
There was a problem hiding this comment.
We have the option to not have this step in the install, but would need this instanceProfile for this to work.
njtran
changed the title
ellistarn
reviewed
Jul 5, 2022
ellistarn
reviewed
Jul 5, 2022
ellistarn
reviewed
Jul 6, 2022
| - name: test-cluster-name | ||
| value: "testing-ci-cluster" | ||
| - name: karpenter-version | ||
| value: "v0.13.1" |
There was a problem hiding this comment.
This is gonna require some helm funkiness, since help doesn't support v as a prefix.
ellistarn
reviewed
Jul 6, 2022
Comment on lines
37
to
45
| - name: spot-slr | ||
| image: amazon/aws-cli | ||
| script: | | ||
| aws iam create-service-linked-role --aws-service-name spot.amazonaws.com || true |
There was a problem hiding this comment.
Since this is a one time action, I think we can probably just remove it.
ellistarn
reviewed
Jul 6, 2022
| aws iam create-service-linked-role --aws-service-name spot.amazonaws.com || true | ||
|
|
||
| - name: helm-install-karpenter | ||
| image: alpine/helm:latest |
There was a problem hiding this comment.
drop :latest, means the same thing.
ellistarn
reviewed
Jul 6, 2022
| --parameter-overrides "ClusterName=$(params.test-cluster-name)" | ||
|
|
||
| ROLE=" - rolearn: arn:aws:iam::$(params.account-id):role/KarpenterNodeRole-$(params.test-cluster-name)\n username: system:node:{{EC2PrivateDNSName}}\n groups:\n - system:nodes\n - system:bootstrappers" | ||
| kubectl get -n kube-system configmap/aws-auth -o yaml | awk "/mapRoles: \|/{print;print \"$ROLE\";next}1" > /tmp/aws-auth-patch.yml |
ellistarn
approved these changes
Jul 12, 2022
This was referenced Jul 13, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How was this change tested?
Does this change impact docs?
Release Note
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.