-
Notifications
You must be signed in to change notification settings - Fork 951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Expand cluster installation test configs #2022
Conversation
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
resources: | ||
cpu: 1k | ||
provider: | ||
instanceProfile: KitDP-$(params.test-cluster-name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have the option to not have this step in the install, but would need this instanceProfile for this to work.
- name: test-cluster-name | ||
value: "testing-ci-cluster" | ||
- name: karpenter-version | ||
value: "v0.13.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is gonna require some helm funkiness, since help doesn't support v
as a prefix.
- name: spot-slr | ||
image: amazon/aws-cli | ||
script: | | ||
aws iam create-service-linked-role --aws-service-name spot.amazonaws.com || true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a one time action, I think we can probably just remove it.
aws iam create-service-linked-role --aws-service-name spot.amazonaws.com || true | ||
|
||
- name: helm-install-karpenter | ||
image: alpine/helm:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drop :latest
, means the same thing.
--parameter-overrides "ClusterName=$(params.test-cluster-name)" | ||
|
||
ROLE=" - rolearn: arn:aws:iam::$(params.account-id):role/KarpenterNodeRole-$(params.test-cluster-name)\n username: system:node:{{EC2PrivateDNSName}}\n groups:\n - system:nodes\n - system:bootstrappers" | ||
kubectl get -n kube-system configmap/aws-auth -o yaml | awk "/mapRoles: \|/{print;print \"$ROLE\";next}1" > /tmp/aws-auth-patch.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check out -ojsonpath
Description
How was this change tested?
Does this change impact docs?
Release Note
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.