-
Notifications
You must be signed in to change notification settings - Fork 967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[aws-cloudwatch-metrics] add tolerations, nodeSelector, affinity #606
Conversation
add nodeSelector, affinity, tolerations
Any update on this ? It would help to have this in place for our EKS systems |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chmoon93 sincere apologies for the long delay in reviewing and merging this. looks great to me.
@jaypipes thanks for your quick response, now I've tried to use it, but the CircleCI pipeline says:
Is this expected? If yes, when can I expect this to be released? I need to roll this out and if it's not in the repository, I will have to download the chart for now. A quick update when I can expect this to be published would be great, thanks in advance! Edit: I've already figured, no tag has been set to |
Looks like there's some bug in our release automation... I will check with @bwagner5 and @jayanthvn and figure it out. |
@jaypipes thanks again, right now I've got the agents running with the downloaded chart, works perfectly, will update as soon as a tag is pushed. I think above is not a bug, but expected behavior, see edit on my old comment. Anyway, since this is already working, maybe you want to close the duplicate PRs here: #585 and #540 |
Issue
[aws-cloudwatch-metrics] add node affinity to the chart #427
currently, aws-cloudwatch-metrics chart do not support nodeSelector, tolerations, affinity.
Description of changes
added tolerations, affinity, nodeSelector options
Checklist
README.md
for modified charts)version
inChart.yaml
for the modified chart(s)Testing
it tested by eks cluster
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.