Support tolerations on aws-cloudwatch-metrics chart daemonset. #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewmrichter
requested review from
bwagner5,
jaypipes and
kishorj
as code owners
4 tasks
|
Looks like duped by #606 - closing. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
None
Description of changes
It's my understanding I need the aws-cloudwatch-metrics chart on all EKS nodes, and I'd like to do that by setting a toleration on the daemonset pods.
Checklist
README.mdfor modified charts)versioninChart.yamlfor the modified chart(s)Testing
I forked this and deployed locally to an EKS cluster I am supporting with success.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.