Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update patches and CHECKSUMS for CAPC v0.5.0 #3964

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

sp1999
Copy link
Member

@sp1999 sp1999 commented Oct 23, 2024

Issue #, if available:
#2399

Description of changes:
A patch to update the minor version in metadata.yaml was added in #3741 to fix the CloudStack tests failing with a version validation error. But that fixed only the cluster creation tests. In order to fix the cluster upgrade tests, we need to have both the minor release version 4 and 5 in the metadata.yaml to pass the validations as currently the CloudStack OIDC tests fail with the following error:

Error: invalid provider metadata: version v0.4.10-rc1+d263e1a (the current version) for 
the provider capc-system/infrastructure-cloudstack does not match any release series

This PR adds a new patch updating the release series to include both the minor versions in order to fix the upgrade tests.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sp1999
Copy link
Member Author

sp1999 commented Oct 23, 2024

/cherry-pick release-0.21

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: once the present PR merges, I will cherry-pick it on top of release-0.21 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 23, 2024
@jhaanvi5
Copy link
Member

/approve
/lgtm

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhaanvi5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 75c1ea3 into aws:main Oct 23, 2024
2 checks passed
@sp1999 sp1999 deleted the update-capc-patch branch October 23, 2024 20:43
@eks-distro-pr-bot
Copy link
Contributor

@sp1999: new pull request created: #3965

In response to this:

/cherry-pick release-0.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants