-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump kubernetes-sigs/cluster-api-provider-cloudstack to latest release #3409
Bump kubernetes-sigs/cluster-api-provider-cloudstack to latest release #3409
Conversation
This pull request is incomplete!Failed patch detailsOnly 0/1 patches were applied! The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated. |
Hi @eks-distro-pr-bot. Thanks for your PR. I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This pull request is incomplete!Failed patch detailsOnly 0/1 patches were applied! The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated. |
2f47273
to
51ffc1f
Compare
This pull request is incomplete!Failed patch detailsOnly 0/1 patches were applied! The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated. |
51ffc1f
to
ba69615
Compare
This pull request is incomplete!Failed patch detailsOnly 0/1 patches were applied! The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated. |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sp1999 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ba69615
to
bf6bb50
Compare
This pull request is incomplete!Failed patch detailsOnly 0/1 patches were applied! The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated. |
bf6bb50
to
d9fd0d4
Compare
This pull request is incomplete!Failed patch detailsOnly 0/1 patches were applied! The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated. |
d9fd0d4
to
12b9653
Compare
This pull request is incomplete!Failed patch detailsOnly 0/1 patches were applied! The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated. |
1 similar comment
This pull request is incomplete!Failed patch detailsOnly 0/1 patches were applied! The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated. |
34e3389
to
bd3a68a
Compare
This pull request is incomplete!Failed patch detailsOnly 0/1 patches were applied! The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated. |
ecd70a6
to
c5663f2
Compare
This pull request is incomplete!Failed patch detailsOnly 0/1 patches were applied! The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated. |
c5663f2
to
42a8d8d
Compare
This pull request is incomplete!Failed patch detailsOnly 0/1 patches were applied! The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated. |
42a8d8d
to
50b8dea
Compare
This pull request is incomplete!Failed patch detailsOnly 0/1 patches were applied! The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated. |
50b8dea
to
3cd957e
Compare
This pull request is incomplete!Failed patch detailsOnly 0/1 patches were applied! The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated. |
1 similar comment
This pull request is incomplete!Failed patch detailsOnly 0/1 patches were applied! The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated. |
3cd957e
to
80230ad
Compare
This pull request is incomplete!Failed patch detailsOnly 0/1 patches were applied! The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated. |
80230ad
to
c6799bd
Compare
This pull request is incomplete!Failed patch detailsOnly 0/1 patches were applied! The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated. |
c6799bd
to
814e80a
Compare
This pull request is incomplete!Failed patch detailsOnly 0/1 patches were applied! The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated. |
814e80a
to
147eb92
Compare
This pull request is incomplete!Failed patch detailsOnly 0/1 patches were applied! The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated. |
147eb92
to
9e77aaf
Compare
9e77aaf
to
feed0c6
Compare
This pull request is incomplete!Failed patch detailsOnly 0/1 patches were applied! The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated. |
/lgtm |
This PR bumps kubernetes-sigs/cluster-api-provider-cloudstack to the latest Git revision.
Compare changes
Release notes
/hold
/area dependencies
Patch Updates:
Changes introduced in CAPC v0.5.0 which required updating the 0001-Support-re-assignment-of-another-failure-domain-when.patch patch:
Reconcile CAPC Cluster as CloudStack CKS Cluster (Default: Opt Out) [#350]
This PR introduces logic that can reconcile a CAPC cluster to a CKS cluster adding new cks_cluster_controller and cks_machine_controller controllers for reconciling a CKS cluster. Our patch updated the AsFailureDomainUser method to also pass in the context as a parameter. The new controllers introduced call this method in their Reconcile functions. Updated the patch to add context in the utility method calls for these new controllers.
Add project support [#356]
This PR added Project support in the CloudStackFailureDomain spec and added the project parameter in some cloud client functions like NewClientFromK8sSecret and NewClientInDomainAndAccount which are called by the
pkg/failuredomains/client
added in our patch. Updated the patch to pass in the Project in those functions from the failure domain spec.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.