Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump kubernetes-sigs/cluster-api-provider-cloudstack to latest release #3409

Conversation

eks-distro-pr-bot
Copy link
Contributor

@eks-distro-pr-bot eks-distro-pr-bot commented Jul 5, 2024

This PR bumps kubernetes-sigs/cluster-api-provider-cloudstack to the latest Git revision.

Compare changes
Release notes

/hold
/area dependencies

Patch Updates:

Changes introduced in CAPC v0.5.0 which required updating the 0001-Support-re-assignment-of-another-failure-domain-when.patch patch:

  1. Reconcile CAPC Cluster as CloudStack CKS Cluster (Default: Opt Out) [#350]
    This PR introduces logic that can reconcile a CAPC cluster to a CKS cluster adding new cks_cluster_controller and cks_machine_controller controllers for reconciling a CKS cluster. Our patch updated the AsFailureDomainUser method to also pass in the context as a parameter. The new controllers introduced call this method in their Reconcile functions. Updated the patch to add context in the utility method calls for these new controllers.

  2. Add project support [#356]
    This PR added Project support in the CloudStackFailureDomain spec and added the project parameter in some cloud client functions like NewClientFromK8sSecret and NewClientInDomainAndAccount which are called by the pkg/failuredomains/client added in our patch. Updated the patch to pass in the Project in those functions from the failure domain spec.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete!

Failed patch details

Only 0/1 patches were applied!
Patch failed at 0001 Support re-assignment of another failure domain when the machine failed to provision
The following files in the above patch did not apply successfully:
controllers/cloudstackfailuredomain_controller.go,controllers/cloudstackmachine_controller.go,controllers/controllers_suite_test.go,controllers/utils/failuredomains.go,pkg/cloud/instance.go,pkg/cloud/network.go

The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated.

@eks-distro-bot
Copy link
Collaborator

Hi @eks-distro-pr-bot. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot added needs-ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 5, 2024
@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete!

Failed patch details

Only 0/1 patches were applied!
Patch failed at 0001 Support re-assignment of another failure domain when the machine failed to provision
The following files in the above patch did not apply successfully:
controllers/cloudstackfailuredomain_controller.go,controllers/cloudstackmachine_controller.go,controllers/controllers_suite_test.go,controllers/utils/failuredomains.go,pkg/cloud/instance.go,pkg/cloud/network.go

The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated.

@eks-distro-pr-bot eks-distro-pr-bot force-pushed the update-kubernetes-sigs-cluster-api-provider-cloudstack-main branch 2 times, most recently from 2f47273 to 51ffc1f Compare July 7, 2024 08:05
@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete!

Failed patch details

Only 0/1 patches were applied!
Patch failed at 0001 Support re-assignment of another failure domain when the machine failed to provision
The following files in the above patch did not apply successfully:
controllers/cloudstackfailuredomain_controller.go,controllers/cloudstackmachine_controller.go,controllers/controllers_suite_test.go,controllers/utils/failuredomains.go,pkg/cloud/instance.go,pkg/cloud/network.go

The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated.

@eks-distro-pr-bot eks-distro-pr-bot force-pushed the update-kubernetes-sigs-cluster-api-provider-cloudstack-main branch from 51ffc1f to ba69615 Compare July 8, 2024 08:05
@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete!

Failed patch details

Only 0/1 patches were applied!
Patch failed at 0001 Support re-assignment of another failure domain when the machine failed to provision
The following files in the above patch did not apply successfully:
controllers/cloudstackfailuredomain_controller.go,controllers/cloudstackmachine_controller.go,controllers/controllers_suite_test.go,controllers/utils/failuredomains.go,pkg/cloud/instance.go,pkg/cloud/network.go

The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated.

@sp1999
Copy link
Member

sp1999 commented Jul 8, 2024

/ok-to-test
/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sp1999

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-pr-bot eks-distro-pr-bot force-pushed the update-kubernetes-sigs-cluster-api-provider-cloudstack-main branch from ba69615 to bf6bb50 Compare July 11, 2024 08:06
@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete!

Failed patch details

Only 0/1 patches were applied!
Patch failed at 0001 Support re-assignment of another failure domain when the machine failed to provision
The following files in the above patch did not apply successfully:
controllers/cloudstackfailuredomain_controller.go,controllers/cloudstackmachine_controller.go,controllers/controllers_suite_test.go,controllers/utils/failuredomains.go,pkg/cloud/instance.go,pkg/cloud/network.go

The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated.

@eks-distro-pr-bot eks-distro-pr-bot force-pushed the update-kubernetes-sigs-cluster-api-provider-cloudstack-main branch from bf6bb50 to d9fd0d4 Compare July 12, 2024 08:06
@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete!

Failed patch details

Only 0/1 patches were applied!
Patch failed at 0001 Support re-assignment of another failure domain when the machine failed to provision
The following files in the above patch did not apply successfully:
controllers/cloudstackfailuredomain_controller.go,controllers/cloudstackmachine_controller.go,controllers/controllers_suite_test.go,controllers/utils/failuredomains.go,pkg/cloud/instance.go,pkg/cloud/network.go

The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated.

@eks-distro-pr-bot eks-distro-pr-bot force-pushed the update-kubernetes-sigs-cluster-api-provider-cloudstack-main branch from d9fd0d4 to 12b9653 Compare July 13, 2024 08:08
@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete!

Failed patch details

Only 0/1 patches were applied!
Patch failed at 0001 Support re-assignment of another failure domain when the machine failed to provision
The following files in the above patch did not apply successfully:
controllers/cloudstackfailuredomain_controller.go,controllers/cloudstackmachine_controller.go,controllers/controllers_suite_test.go,controllers/utils/failuredomains.go,pkg/cloud/instance.go,pkg/cloud/network.go

The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated.

1 similar comment
@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete!

Failed patch details

Only 0/1 patches were applied!
Patch failed at 0001 Support re-assignment of another failure domain when the machine failed to provision
The following files in the above patch did not apply successfully:
controllers/cloudstackfailuredomain_controller.go,controllers/cloudstackmachine_controller.go,controllers/controllers_suite_test.go,controllers/utils/failuredomains.go,pkg/cloud/instance.go,pkg/cloud/network.go

The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated.

@eks-distro-pr-bot eks-distro-pr-bot force-pushed the update-kubernetes-sigs-cluster-api-provider-cloudstack-main branch 2 times, most recently from 34e3389 to bd3a68a Compare July 15, 2024 08:08
@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete!

Failed patch details

Only 0/1 patches were applied!
Patch failed at 0001 Support re-assignment of another failure domain when the machine failed to provision
The following files in the above patch did not apply successfully:
controllers/cloudstackfailuredomain_controller.go,controllers/cloudstackmachine_controller.go,controllers/controllers_suite_test.go,controllers/utils/failuredomains.go,pkg/cloud/instance.go,pkg/cloud/network.go

The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated.

@eks-distro-pr-bot eks-distro-pr-bot force-pushed the update-kubernetes-sigs-cluster-api-provider-cloudstack-main branch from ecd70a6 to c5663f2 Compare August 28, 2024 08:07
@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete!

Failed patch details

Only 0/1 patches were applied!
Patch failed at 0001 Support re-assignment of another failure domain when the machine failed to provision
The following files in the above patch did not apply successfully:
controllers/cloudstackfailuredomain_controller.go,controllers/cloudstackmachine_controller.go,controllers/controllers_suite_test.go,controllers/utils/failuredomains.go,pkg/cloud/instance.go,pkg/cloud/network.go

The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated.

@eks-distro-pr-bot eks-distro-pr-bot force-pushed the update-kubernetes-sigs-cluster-api-provider-cloudstack-main branch from c5663f2 to 42a8d8d Compare August 29, 2024 08:08
@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete!

Failed patch details

Only 0/1 patches were applied!
Patch failed at 0001 Support re-assignment of another failure domain when the machine failed to provision
The following files in the above patch did not apply successfully:
controllers/cloudstackfailuredomain_controller.go,controllers/cloudstackmachine_controller.go,controllers/controllers_suite_test.go,controllers/utils/failuredomains.go,pkg/cloud/instance.go,pkg/cloud/network.go

The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated.

@eks-distro-pr-bot eks-distro-pr-bot force-pushed the update-kubernetes-sigs-cluster-api-provider-cloudstack-main branch from 42a8d8d to 50b8dea Compare August 30, 2024 08:06
@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete!

Failed patch details

Only 0/1 patches were applied!
Patch failed at 0001 Support re-assignment of another failure domain when the machine failed to provision
The following files in the above patch did not apply successfully:
controllers/cloudstackfailuredomain_controller.go,controllers/cloudstackmachine_controller.go,controllers/controllers_suite_test.go,controllers/utils/failuredomains.go,pkg/cloud/instance.go,pkg/cloud/network.go

The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated.

@eks-distro-pr-bot eks-distro-pr-bot force-pushed the update-kubernetes-sigs-cluster-api-provider-cloudstack-main branch from 50b8dea to 3cd957e Compare August 31, 2024 08:07
@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete!

Failed patch details

Only 0/1 patches were applied!
Patch failed at 0001 Support re-assignment of another failure domain when the machine failed to provision
The following files in the above patch did not apply successfully:
controllers/cloudstackfailuredomain_controller.go,controllers/cloudstackmachine_controller.go,controllers/controllers_suite_test.go,controllers/utils/failuredomains.go,pkg/cloud/instance.go,pkg/cloud/network.go

The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated.

1 similar comment
@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete!

Failed patch details

Only 0/1 patches were applied!
Patch failed at 0001 Support re-assignment of another failure domain when the machine failed to provision
The following files in the above patch did not apply successfully:
controllers/cloudstackfailuredomain_controller.go,controllers/cloudstackmachine_controller.go,controllers/controllers_suite_test.go,controllers/utils/failuredomains.go,pkg/cloud/instance.go,pkg/cloud/network.go

The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated.

@eks-distro-pr-bot eks-distro-pr-bot force-pushed the update-kubernetes-sigs-cluster-api-provider-cloudstack-main branch from 3cd957e to 80230ad Compare September 1, 2024 08:06
@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete!

Failed patch details

Only 0/1 patches were applied!
Patch failed at 0001 Support re-assignment of another failure domain when the machine failed to provision
The following files in the above patch did not apply successfully:
controllers/cloudstackfailuredomain_controller.go,controllers/cloudstackmachine_controller.go,controllers/controllers_suite_test.go,controllers/utils/failuredomains.go,pkg/cloud/instance.go,pkg/cloud/network.go

The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated.

@eks-distro-pr-bot eks-distro-pr-bot force-pushed the update-kubernetes-sigs-cluster-api-provider-cloudstack-main branch from 80230ad to c6799bd Compare September 2, 2024 08:06
@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete!

Failed patch details

Only 0/1 patches were applied!
Patch failed at 0001 Support re-assignment of another failure domain when the machine failed to provision
The following files in the above patch did not apply successfully:
controllers/cloudstackfailuredomain_controller.go,controllers/cloudstackmachine_controller.go,controllers/controllers_suite_test.go,controllers/utils/failuredomains.go,pkg/cloud/instance.go,pkg/cloud/network.go

The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated.

@eks-distro-pr-bot eks-distro-pr-bot force-pushed the update-kubernetes-sigs-cluster-api-provider-cloudstack-main branch from c6799bd to 814e80a Compare September 3, 2024 08:06
@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete!

Failed patch details

Only 0/1 patches were applied!
Patch failed at 0001 Support re-assignment of another failure domain when the machine failed to provision
The following files in the above patch did not apply successfully:
controllers/cloudstackfailuredomain_controller.go,controllers/cloudstackmachine_controller.go,controllers/controllers_suite_test.go,controllers/utils/failuredomains.go,pkg/cloud/instance.go,pkg/cloud/network.go

The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated.

@eks-distro-pr-bot eks-distro-pr-bot force-pushed the update-kubernetes-sigs-cluster-api-provider-cloudstack-main branch from 814e80a to 147eb92 Compare September 4, 2024 08:07
@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete!

Failed patch details

Only 0/1 patches were applied!
Patch failed at 0001 Support re-assignment of another failure domain when the machine failed to provision
The following files in the above patch did not apply successfully:
controllers/cloudstackfailuredomain_controller.go,controllers/cloudstackmachine_controller.go,controllers/controllers_suite_test.go,controllers/utils/failuredomains.go,pkg/cloud/instance.go,pkg/cloud/network.go

The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated.

@eks-distro-pr-bot eks-distro-pr-bot force-pushed the update-kubernetes-sigs-cluster-api-provider-cloudstack-main branch from 147eb92 to 9e77aaf Compare September 5, 2024 08:06
@eks-distro-pr-bot eks-distro-pr-bot force-pushed the update-kubernetes-sigs-cluster-api-provider-cloudstack-main branch from 9e77aaf to feed0c6 Compare September 6, 2024 08:06
@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete!

Failed patch details

Only 0/1 patches were applied!
Patch failed at 0001 Support re-assignment of another failure domain when the machine failed to provision
The following files in the above patch did not apply successfully:
controllers/cloudstackfailuredomain_controller.go,controllers/cloudstackmachine_controller.go,controllers/controllers_suite_test.go,controllers/utils/failuredomains.go,pkg/cloud/instance.go,pkg/cloud/network.go

The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated.

@eks-distro-bot eks-distro-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 7, 2024
@sp1999
Copy link
Member

sp1999 commented Sep 7, 2024

/lgtm
/unhold

@eks-distro-bot eks-distro-bot merged commit 4627269 into aws:main Sep 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependencies lgtm ok-to-test size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants