Re-add AWS V3 Instrumentation #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* build core files to dist directory * fixed unit tests * updated workflows and readme * try to fix windows * fix ls * slashes * no more ls * zstd decompress * see what bin has * removed rsync * fixes * added sh * try xargs instead * cleanups * fixed publishing logic
* updated deps and type file * removed type keyword added deps * remove changes to js * updated versions * finished redesign of aws sdk v3 instrumentation * refactored buildAttributes signature * add compile back to workflow * bumped tsd version instead Co-authored-by: Trivikram Kamat <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #421 +/- ##
==========================================
+ Coverage 82.65% 82.71% +0.05%
==========================================
Files 36 36
Lines 1718 1741 +23
==========================================
+ Hits 1420 1440 +20
- Misses 298 301 +3
Continue to review full report at Codecov.
|
lupengamzn
reviewed
May 12, 2021
lupengamzn
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#294, #411
Description of changes:
This PR officially re-commits AWS SDK V3 instrumentation to the main branch of the repo. To summarize the changes, we have:
corepackage to exclude TS files and only include type declarations and transpiled JS code, as is best practiceGenerally, the changes in this PR have already been reviewed in #386, #416, and #417. The only additional changes are those mentioned in point 3.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.