Revert PR #386 #412
Merged
Revert PR #386 #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 12, 2021 15:55
|
Added a no-op version of the removed API to ensure backwards-compatbility in patch version. |
lupengamzn
approved these changes
Apr 12, 2021
willarmiros
pushed a commit
to willarmiros/aws-xray-sdk-node
that referenced
this pull request
Apr 13, 2021
willarmiros
pushed a commit
that referenced
this pull request
Apr 13, 2021
willarmiros
added a commit
that referenced
this pull request
May 12, 2021
* Revert "Revert PR #386 (#412)" This reverts commit 9e20d2e. * Add proper TypeScript build logic (#417) * build core files to dist directory * fixed unit tests * updated workflows and readme * try to fix windows * fix ls * slashes * no more ls * zstd decompress * see what bin has * removed rsync * fixes * added sh * try xargs instead * cleanups * fixed publishing logic * Redesign AWS SDK V3 instrumentation to use middleware (#416) * updated deps and type file * removed type keyword added deps * remove changes to js * updated versions * finished redesign of aws sdk v3 instrumentation * refactored buildAttributes signature * add compile back to workflow * bumped tsd version instead Co-authored-by: Trivikram Kamat <[email protected]> * removed dependencies and added docs * add back most changes, update types * removed aws-v3 branch from CI * fixed codecov to use dist directory * added blog post link Co-authored-by: Trivikram Kamat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#411
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.