Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not support old versions of Rails + Ruby / Prepare for 4.0.0 #129

Merged
merged 5 commits into from
Jun 24, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 2 additions & 25 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,33 +15,10 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: [2.5, 2.6, 2.7, '3.0', 3.1, 3.2, 3.3, jruby-9.2, jruby-9.3, jruby-9.4]
gemfile: [rails-5.2.gemfile, rails-6.0.gemfile, rails-6.1.gemfile, rails-7.0.gemfile, rails-main.gemfile]
ruby: [2.7, '3.0', 3.1, 3.2, 3.3, jruby-9.2, jruby-9.3, jruby-9.4]
ssunday marked this conversation as resolved.
Show resolved Hide resolved
gemfile: [rails-7.0.gemfile, rails-main.gemfile]
ssunday marked this conversation as resolved.
Show resolved Hide resolved

exclude:
# Rails 5 does not work with Ruby 3
- gemfile: rails-5.2.gemfile
ruby: '3.0'
- gemfile: rails-5.2.gemfile
ruby: 3.1
- gemfile: rails-5.2.gemfile
ruby: 3.2
- gemfile: rails-5.2.gemfile
ruby: 3.3
- gemfile: rails-5.2.gemfile
ruby: jruby-9.4

# Rails 7 requires Ruby >= 2.7
- gemfile: rails-7.0.gemfile
ruby: 2.5
- gemfile: rails-main.gemfile
ruby: 2.5

- gemfile: rails-7.0.gemfile
ruby: 2.6
- gemfile: rails-main.gemfile
ruby: 2.6

- gemfile: rails-7.0.gemfile
ruby: jruby-9.2
- gemfile: rails-main.gemfile
Expand Down
2 changes: 1 addition & 1 deletion VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.13.0
4.0.0
8 changes: 0 additions & 8 deletions gemfiles/rails-5.2.gemfile

This file was deleted.

5 changes: 0 additions & 5 deletions gemfiles/rails-6.0.gemfile

This file was deleted.

5 changes: 0 additions & 5 deletions gemfiles/rails-6.1.gemfile

This file was deleted.

2 changes: 1 addition & 1 deletion sample_app/Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: ..
specs:
aws-sdk-rails (3.12.0)
aws-sdk-rails (4.0.0)
ssunday marked this conversation as resolved.
Show resolved Hide resolved
aws-record (~> 2)
aws-sdk-ses (~> 1, >= 1.50.0)
aws-sdk-sesv2 (~> 1, >= 1.34.0)
Expand Down
1 change: 1 addition & 0 deletions test/test_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
require 'rspec/expectations/minitest_integration'

ENV['RAILS_ENV'] = 'test'

require_relative 'dummy/config/application'

Rails.application.initialize!
Expand Down
Loading