Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not support old versions of Rails + Ruby / Prepare for 4.0.0 #129

Merged
merged 5 commits into from
Jun 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 2 additions & 35 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,43 +15,10 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: [2.5, 2.6, 2.7, '3.0', 3.1, 3.2, 3.3, jruby-9.2, jruby-9.3, jruby-9.4]
gemfile: [rails-5.2.gemfile, rails-6.0.gemfile, rails-6.1.gemfile, rails-7.0.gemfile, rails-main.gemfile]
ruby: [2.7, '3.0', 3.1, 3.2, 3.3, jruby-9.4]
gemfile: [rails-7.0.gemfile, rails-7.1.gemfile, rails-main.gemfile]

exclude:
# Rails 5 does not work with Ruby 3
- gemfile: rails-5.2.gemfile
ruby: '3.0'
- gemfile: rails-5.2.gemfile
ruby: 3.1
- gemfile: rails-5.2.gemfile
ruby: 3.2
- gemfile: rails-5.2.gemfile
ruby: 3.3
- gemfile: rails-5.2.gemfile
ruby: jruby-9.4

# Rails 7 requires Ruby >= 2.7
- gemfile: rails-7.0.gemfile
ruby: 2.5
- gemfile: rails-main.gemfile
ruby: 2.5

- gemfile: rails-7.0.gemfile
ruby: 2.6
- gemfile: rails-main.gemfile
ruby: 2.6

- gemfile: rails-7.0.gemfile
ruby: jruby-9.2
- gemfile: rails-main.gemfile
ruby: jruby-9.2

- gemfile: rails-7.0.gemfile
ruby: jruby-9.3
- gemfile: rails-main.gemfile
ruby: jruby-9.3

# Rails 7.1 dropped support for older rubygems
- gemfile: rails-main.gemfile
ruby: 2.7
Expand Down
3 changes: 1 addition & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,11 @@
.yardoc
.ruby-version
*.gem
*.gemfile.lock
coverage
doc
docs.zip
Gemfile.lock
!/sample_app/Gemfile.lock
sample_app/Gemfile.lock
test/dummy/db/migrate
test/dummy/log/
test/dummy/tmp/
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ the latest version of [AWS SDK For Ruby](https://github.com/aws/aws-sdk-ruby).
Add this gem to your Rails project's Gemfile:

```ruby
gem 'aws-sdk-rails'
gem 'aws-sdk-rails', '~> 4'
```

This gem also brings in the following AWS gems:
Expand All @@ -28,7 +28,7 @@ If you want to use other services (such as S3), you will still need to add them
Gemfile:

```ruby
gem 'aws-sdk-rails', '~> 3'
gem 'aws-sdk-rails', '~> 4'
gem 'aws-sdk-s3', '~> 1'
```

Expand Down
8 changes: 0 additions & 8 deletions gemfiles/rails-5.2.gemfile

This file was deleted.

5 changes: 0 additions & 5 deletions gemfiles/rails-6.1.gemfile

This file was deleted.

2 changes: 1 addition & 1 deletion gemfiles/rails-6.0.gemfile → gemfiles/rails-7.1.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@

eval_gemfile '../Gemfile'

gem 'rails', '~> 6.0.0'
gem 'rails', '~> 7.1.0'
Loading
Loading