Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for array equality bug in the Node.js XML parser #3430

Merged
merged 2 commits into from
Sep 2, 2020
Merged

Fix for array equality bug in the Node.js XML parser #3430

merged 2 commits into from
Sep 2, 2020

Conversation

mhart
Copy link
Contributor

@mhart mhart commented Sep 1, 2020

Array equality bug in the Node.js XML parser

Checklist
  • npm run test passes
  • changelog is added, npm run add-change

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-v2-github
  • Commit ID: 56126aa
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mhart
Copy link
Contributor Author

mhart commented Sep 2, 2020

Was just pointed to #3325 which raises this exact issue – seems it was closed erroneously

@mhart mhart mentioned this pull request Sep 2, 2020
3 tasks
@trivikr trivikr self-requested a review September 2, 2020 15:36
@trivikr
Copy link
Member

trivikr commented Sep 2, 2020

@mhart Please run npm run add-change to add a changelog entry for bugfix for this PR

@mhart
Copy link
Contributor Author

mhart commented Sep 2, 2020

@trivikr it would be great if the CI process could do that – would save ppl having to actually clone the repository locally, install everything, etc.

@trivikr trivikr changed the title Can't compare arrays directly in JS Fix for array equality bug in the Node.js XML parser Sep 2, 2020
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-v2-github
  • Commit ID: 124bfc9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mhart
Copy link
Contributor Author

mhart commented Sep 2, 2020

I added a unit test to ensure this branch is tested too

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-v2-github
  • Commit ID: 4561b33
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr trivikr merged commit f9642f5 into aws:master Sep 2, 2020
@trivikr
Copy link
Member

trivikr commented Sep 2, 2020

Thank you @mhart for the fix, and @blacha for suggesting it in #3325
It's now merged, and will be released with v2.745.0 around 12 noon PST on 9/2

@mhart mhart deleted the patch-2 branch September 2, 2020 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants