-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for array equality bug in the Node.js XML parser #3430
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Was just pointed to #3325 which raises this exact issue – seems it was closed erroneously |
@mhart Please run |
@trivikr it would be great if the CI process could do that – would save ppl having to actually clone the repository locally, install everything, etc. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
I added a unit test to ensure this branch is tested too |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Array equality bug in the Node.js XML parser
Checklist
npm run test
passesnpm run add-change