Can't compare arrays directly in JS

aws · Sep 2, 2020 · 124bfc9 · 124bfc9
1 parent b3b33bf
commit 124bfc9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changes/next-release/bugfix-XML-c6eb8219.json b/.changes/next-release/bugfix-XML-c6eb8219.json
@@ -0,0 +1,5 @@
+{
+  "type": "bugfix",
+  "category": "XML",
+  "description": "Fixed an array equality bug in the Node.js XML parser"
+}
diff --git a/lib/xml/node_parser.js b/lib/xml/node_parser.js
@@ -139,7 +139,7 @@ function parseUnknown(xml) {
 
   // empty object
   var keys = Object.keys(xml), i;
-  if (keys.length === 0 || keys === ['$']) {
+  if (keys.length === 0 || (keys.length === 1 && keys[0] === '$')) {
     return {};
   }