Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: codegen decode escaped xml #959

Merged
merged 1 commit into from
Mar 2, 2020

Conversation

srchase
Copy link
Contributor

@srchase srchase commented Feb 28, 2020

Codegen for #952

Adds function to decode escaped xml.

Updates generateXmlParseBody in code generation to use new function as tagValueProcessor for fast-xml-parser.

Fixes #950

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@srchase srchase requested a review from AllanZhengYP February 28, 2020 20:53
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-io
Copy link

Codecov Report

Merging #959 into smithy-codegen will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           smithy-codegen     #959   +/-   ##
===============================================
  Coverage           91.58%   91.58%           
===============================================
  Files                 147      147           
  Lines                2912     2912           
  Branches              507      507           
===============================================
  Hits                 2667     2667           
  Misses                245      245

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dceadb...d44c726. Read the comment docs.

@AllanZhengYP AllanZhengYP merged commit a9d87f9 into aws:smithy-codegen Mar 2, 2020
@srchase srchase deleted the chore-escape-xml branch March 2, 2020 17:43
@lock
Copy link

lock bot commented Mar 10, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants