Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decode escaped XML #952

Merged
merged 3 commits into from
Feb 28, 2020
Merged

Conversation

srchase
Copy link
Contributor

@srchase srchase commented Feb 26, 2020

Fixes #950

Adds function to decode escaped xml.

Updates generateXmlParseBody in code generation to use new function as tagValueProcessor for fast-xml-parser.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-io
Copy link

codecov-io commented Feb 26, 2020

Codecov Report

Merging #952 into smithy-codegen will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           smithy-codegen     #952   +/-   ##
===============================================
  Coverage           91.58%   91.58%           
===============================================
  Files                 147      147           
  Lines                2912     2912           
  Branches              507      507           
===============================================
  Hits                 2667     2667           
  Misses                245      245

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3049f3d...fcd378d. Read the comment docs.

Copy link
Contributor

@kstich kstich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding this as a new export to the smithy-client package, can it be made private and generated into the protocol file directly from a resource file?

@srchase srchase requested a review from kstich February 28, 2020 19:09
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@srchase srchase merged commit 7dceadb into aws:smithy-codegen Feb 28, 2020
@srchase srchase deleted the decode-escaped-xml branch February 28, 2020 19:42
AllanZhengYP pushed a commit that referenced this pull request Mar 2, 2020
* Codegen for fixing decode escaped XML([#952](#952))
@lock
Copy link

lock bot commented Mar 10, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants