Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement return values for enhanced UpdateItem #2748

Merged
merged 2 commits into from
Oct 5, 2021
Merged

Implement return values for enhanced UpdateItem #2748

merged 2 commits into from
Oct 5, 2021

Conversation

dagnir
Copy link
Contributor

@dagnir dagnir commented Oct 1, 2021 •
edited by debora-ito
Loading

Motivation and Context

Requested feature.

Description

This commit introduces DynamoDbTable#updateItemWithResponse() that allows
customers to specify additional parameters on the request such as
ReturnConsumedCapacity to get additional information the service response.

Similar to #2710.

Relates to #1918, #2095.

Testing

New unit and integration tests.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dagnir
Implement return values for enhanced UpdateItem
6d56a67 
This commit introduces DynamoDbTable#updateItemWithResponse() that allows
customers to specify additional parameters on the request such as
ReturnConsumedCapacity to get additional information the service response.
@sonarcloud
Copy link

sonarcloud bot commented Oct 1, 2021 •
edited
Loading

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

88.6% 88.6% Coverage
14.7% 14.7% Duplication

@dagnir
Copy link
Contributor Author

dagnir commented Oct 1, 2021

Reported bug was a false positive.

@dagnir dagnir marked this pull request as ready for review October 1, 2021 22:25
@aws aws locked and limited conversation to collaborators Oct 5, 2021
@dagnir dagnir merged commit ecc9149 into aws:master Oct 5, 2021
@dagnir dagnir deleted the updateitem-returnvalues branch October 5, 2021 21:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joviegas joviegas joviegas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dagnir @joviegas