-
Notifications
You must be signed in to change notification settings - Fork 856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement return values for enhanced PutItem #2710
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flagged bug is a false positive: if (request.left().isPresent()) {
requestBuilder = addPlainPutItemParameters(requestBuilder, request.left().get()); It says
But we are doing that. |
dagnir
force-pushed
the
putitem-returnvalues
branch
3 times, most recently
from
September 14, 2021 20:28
84f5b62
to
fbbe98e
Compare
dagnir
changed the title
WIP PutItem with response
Implement return values for enhanced PutItem
Sep 14, 2021
dagnir
force-pushed
the
putitem-returnvalues
branch
from
September 14, 2021 20:34
fbbe98e
to
611120c
Compare
dagnir
force-pushed
the
putitem-returnvalues
branch
from
September 15, 2021 19:50
611120c
to
b38bab9
Compare
This commit introduces DynamoDbTable#putItemWithResponse() that allows customers to specify additional parameters on the request such as ReturnValues to get additional information the service response. Relates to aws#1918
dagnir
force-pushed
the
putitem-returnvalues
branch
from
September 15, 2021 20:01
b38bab9
to
40ca5f2
Compare
millems
approved these changes
Sep 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor comment
...main/java/software/amazon/awssdk/enhanced/dynamodb/internal/operations/PutItemOperation.java
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! |
13 tasks
13 tasks
aws-sdk-java-automation
added a commit
that referenced
this pull request
Oct 5, 2023
…ef6b7bb62 Pull request: release <- staging/841c5502-cbe0-48e3-bce9-024ef6b7bb62
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Requested feature.
Description
This commit introduces DynamoDbTable#putItemWithResponse() that allows customers
to specify additional parameters on the request such as ReturnValues to get
additional information the service response.
Relates to #1918, #2095
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn install
succeedsLicense