Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use http_proxy enviroment variable for ProxyConfiguration #1793

Closed
1 task
Jakob-em opened this issue Apr 27, 2020 · 3 comments · Fixed by #2771
Closed
1 task

Use http_proxy enviroment variable for ProxyConfiguration #1793

Jakob-em opened this issue Apr 27, 2020 · 3 comments · Fixed by #2771
Labels
1.x Parity feature-request A feature should be added or improved.

Comments

@Jakob-em
Copy link

Jakob-em commented Apr 27, 2020

Describe the Feature

The ProxyConfiguration should take the values from the http_proxy/https_proxy environment variables. As seen here: aws/aws-sdk-java#1959

Is your Feature Request related to a problem?

I was running into some issues when using a proxy for the connection to s3 and then realised that the system http_proxy was not used for the connection.

  • I may be able to implement this feature request
@Jakob-em Jakob-em added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 27, 2020
@debora-ito debora-ito added 1.x Parity and removed needs-triage This issue or PR still needs to be triaged. labels May 1, 2020
@debora-ito
Copy link
Member

Thank you for reaching out @Jakob-em. This is a reasonable ask, since it's supported in V1.

@mjeffrey
Copy link

mjeffrey commented Apr 15, 2021

We just had the same issue for KMS (we use "https" rather than "http")

-Dhttps.proxyHost and -Dhttps.proxyPort

The problem appears to be in the ProxyConfiguration.resolvePort() and ProxySystemSetting.

If both https.proxy* and http.proxy* are set then you should prefer the https values (I assume all calls are https 😃 ).

A workaround is to set the http.proxy* properties as well.

I'm willing to make a PR if you agree with what I wrote above.

aws-sdk-java-automation added a commit that referenced this issue Oct 26, 2021
…376d714f9

Pull request: release <- staging/3ad03742-c86d-4083-b0ae-a5f376d714f9
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x Parity feature-request A feature should be added or improved.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants