Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use environment variables proxy settings #1959

Closed
benkropf opened this issue Apr 2, 2019 · 3 comments
Closed

Use environment variables proxy settings #1959

benkropf opened this issue Apr 2, 2019 · 3 comments
Labels
feature-request A feature should be added or improved.

Comments

@benkropf
Copy link
Contributor

benkropf commented Apr 2, 2019

Following up to #596, feel free to close this if this has already been implemented, but from what I can tell it has not.

ClientConfiguration should check common environment variables HTTP_PROXY, HTTPS_PROXY and NO_PROXY if neither configured ClientConfiguration variables or Java system properties are set. Precedence would be configured values, then Java system properties, then environment variables.

I'd be happy to have this assigned to me as well if this is something we'd like implemented.

@webbhlin
Copy link

webbhlin commented Apr 3, 2019

+1
I would like to see someone fixes this issue.

@debora-ito
Copy link
Member

Hi @benkropf, this seems a reasonable ask, marking as a feature request. If you can send us a PR, we are happy to take a look.

@debora-ito debora-ito added the feature-request A feature should be added or improved. label Apr 3, 2019
@debora-ito
Copy link
Member

Closed via #1967.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

3 participants