Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DatabaseName in Slurm Accounting integ test #5726

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

jdeamicis
Copy link
Contributor

Description of changes

  • Modify one of the integration tests for Slurm Accounting to use DatabaseName at cluster update to add integ test coverage for the DatabaseName configuration parameter.

Tests

  • Modified and run (successfully) one of the Slurm Accounting integration tests

References

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Modify one of the integration tests for Slurm Accounting to
use DatabaseName at cluster update to add integ test coverage
for the DatabaseName configuration parameter.

Signed-off-by: Jacopo De Amicis <[email protected]>
@jdeamicis jdeamicis added skip-changelog-update Disables the check that enforces changelog updates in PRs 3.x labels Sep 28, 2023
@jdeamicis jdeamicis requested review from a team as code owners September 28, 2023 17:56
@jdeamicis jdeamicis enabled auto-merge (rebase) September 28, 2023 17:57
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (ed37377) 89.89% compared to head (8c47fcd) 89.89%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5726   +/-   ##
========================================
  Coverage    89.89%   89.89%           
========================================
  Files          179      179           
  Lines        15434    15434           
========================================
  Hits         13875    13875           
  Misses        1559     1559           
Flag Coverage Δ
unittests 89.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@davprat davprat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jdeamicis jdeamicis merged commit 3d99208 into aws:develop Sep 28, 2023
@jdeamicis jdeamicis deleted the wip/devel/expose_storageloc branch September 28, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x skip-changelog-update Disables the check that enforces changelog updates in PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants