Add support for Database/Database name to render StorageLoc in slurmdbd configuration #2470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdeamicis
changed the title
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2470 +/- ##
========================================
Coverage 76.06% 76.06%
========================================
Files 13 13
Lines 1876 1876
========================================
Hits 1427 1427
Misses 449 449
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jdeamicis
force-pushed
the
wip/devel/expose_storageloc
branch
2 times, most recently
from
9ef5ef1 to
e9e838d
Compare
EddyMM
reviewed
Sep 27, 2023
cookbooks/aws-parallelcluster-slurm/recipes/install/slurm_users.rb
Outdated
Show resolved
Hide resolved
...ster-slurm/files/default/head_node_slurm/slurm/templates/slurm_parallelcluster_slurmdbd.conf
Show resolved
Hide resolved
jdeamicis
force-pushed
the
wip/devel/expose_storageloc
branch
from
e9e838d to
91adb71
Compare
EddyMM
approved these changes
Sep 27, 2023
Signed-off-by: Jacopo De Amicis <[email protected]>
Signed-off-by: Jacopo De Amicis <[email protected]>
Cover part of the recipe for the configuration of Slurm Accounting with InSpec tests runnable on docker. Signed-off-by: Jacopo De Amicis <[email protected]>
Add logic to use Database/DatabaseName to render StorageLoc in slurm_parallelcluster_slurmdbd.con if provided. The default value remains the name of the cluster (opportunely transformed). Add unit test case to cover creation of slurmdbd conf include file with the usage of Database/DatabaseName in the input YAML file. Add Changelog entry. Signed-off-by: Jacopo De Amicis <[email protected]>
Add trick to have the logic for the renderization of the template indented without affecting the final output. This improves the comprehension of the logic embedded in the template (although slightly visually impacting). Signed-off-by: Jacopo De Amicis <[email protected]>
Simplify unit test for generation of Slurm accounting configuration files. Remove commented parameters in slurm kitchen test configuration file. Modify copyright year in one file. Signed-off-by: Jacopo De Amicis <[email protected]>
jdeamicis
force-pushed
the
wip/devel/expose_storageloc
branch
from
91adb71 to
b401a23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Scheduling/SlurmSettings/Database/DatabaseNameto be used to configureStorageLocin the slurmdbd configuration include file generated by ParallelCluster.config_slurm_accounting.rbrecipe.Tests
config_slurm_accounting.rbrecipe.References
Checklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.