Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[integ-tests-3.7.0][integ-tests] Improve _get_resources_with_image_resource #5701

Merged
merged 2 commits into from
Sep 14, 2023
Merged

[integ-tests-3.7.0][integ-tests] Improve _get_resources_with_image_resource #5701

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d7b322
[integ-tests] Improve _get_resources_with_image_resource
hanwen-cluster Sep 14, 2023
07b886b
Remove dependency on `pytest-travis-fold` (#5685)
EddyMM Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/integration-tests/tests/iam/test_iam_image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ def _get_resources_with_image_resource(cfn_client, stack_name):
image_resource_exists = False
logging.info("Checking image resource")
for resource in resources:
if resource["ResourceType"] == "AWS::ImageBuilder::Image":
if resource["ResourceType"] == "AWS::ImageBuilder::Image" and resource.get("PhysicalResourceId"):
image_resource_exists = True
logging.info("The image resource exists!")
break
Expand Down