[integ-tests-3.7.0][integ-tests] Improve _get_resources_with_image_resource #5701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the resource first appears, the PhysicalResourceId might not be available. Therefore, this commit improves the function to wait until PhysicalResourceId is available Signed-off-by: Hanwen <[email protected]>
hanwen-pcluste
changed the title
hanwen-pcluste
added
the
skip-changelog-update
dreambeyondorange
previously approved these changes
Sep 14, 2023
- Tests run using Github actions now, not TravisCI. - The pytest-travis-fold module is no longer necessary. Signed-off-by: Eddy Mwiti <[email protected]>
dreambeyondorange
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the resource first appears, the PhysicalResourceId might not be available. Therefore, this commit improves the function to wait until PhysicalResourceId is available.
This PR also cherry picks #5685
Tests
test_iam_roles integration test has been passed
Checklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.