Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Install kernel-devel for Rocky Linux from vault #2598

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

enrico-usai
Copy link
Contributor

@enrico-usai enrico-usai commented Dec 12, 2023

Previous releases are moved into a vault area once a new minor release version is available for at least a week. This means we cannot use --releasever to install 8.8 version because it is not more available in the repo.

On RHEL8 instead all versions of the packages will remain available.

With this patch we're downloading this specific package from vault and installing it.

Tests

Manual execution of the new steps.

References

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (25a1a91) 75.56% compared to head (b321ef9) 75.56%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2598   +/-   ##
========================================
  Coverage    75.56%   75.56%           
========================================
  Files           16       16           
  Lines         2132     2132           
========================================
  Hits          1611     1611           
  Misses         521      521           
Flag Coverage Δ
unittests 75.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@enrico-usai enrico-usai enabled auto-merge (rebase) December 12, 2023 10:53
@enrico-usai enrico-usai force-pushed the wip/rocky-devel branch 2 times, most recently from 61d6883 to 6085e34 Compare December 12, 2023 12:16
jdeamicis
jdeamicis previously approved these changes Dec 12, 2023
@enrico-usai enrico-usai disabled auto-merge December 12, 2023 12:26
Previous releases are moved into a vault area once a new minor release version is available for at least a week.
This means we cannot use `--releasever` to install 8.8 version because it is not more available in the repo.

On RHEL8 instead all versions of the packages will remain available.

With this patch we're downloading this specific package from vault and installing it.

## Tests

Manual execution of the new steps.

## References

* https://wiki.rockylinux.org/rocky/repo/#notes-on-devel

Signed-off-by: Enrico Usai <[email protected]>
@enrico-usai enrico-usai merged commit 96cc258 into aws:develop Dec 12, 2023
28 checks passed
@enrico-usai enrico-usai deleted the wip/rocky-devel branch December 12, 2023 17:30
enrico-usai added a commit to enrico-usai/aws-parallelcluster-cookbook that referenced this pull request Dec 14, 2023
This code has been created to try to install using `--releasever` parameter
and if this command fails try to install the package from vault,
anyway the `set -e` at the top of the failing was causing all the build to fail.

Manually tested in a Rocky-8-EC2-Base-8.8-20230518.0.x86_64

Related to: aws#2598

Signed-off-by: Enrico Usai <[email protected]>
enrico-usai added a commit that referenced this pull request Dec 14, 2023
This code has been created to try to install using `--releasever` parameter
and if this command fails try to install the package from vault,
anyway the `set -e` at the top of the failing was causing all the build to fail.

Manually tested in a Rocky-8-EC2-Base-8.8-20230518.0.x86_64

Related to: #2598

Signed-off-by: Enrico Usai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants