-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop] Install kernel-devel for Rocky Linux from vault #2598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2598 +/- ##
========================================
Coverage 75.56% 75.56%
========================================
Files 16 16
Lines 2132 2132
========================================
Hits 1611 1611
Misses 521 521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
enrico-usai
force-pushed
the
wip/rocky-devel
branch
2 times, most recently
from
December 12, 2023 12:16
61d6883
to
6085e34
Compare
jdeamicis
previously approved these changes
Dec 12, 2023
Previous releases are moved into a vault area once a new minor release version is available for at least a week. This means we cannot use `--releasever` to install 8.8 version because it is not more available in the repo. On RHEL8 instead all versions of the packages will remain available. With this patch we're downloading this specific package from vault and installing it. ## Tests Manual execution of the new steps. ## References * https://wiki.rockylinux.org/rocky/repo/#notes-on-devel Signed-off-by: Enrico Usai <[email protected]>
enrico-usai
force-pushed
the
wip/rocky-devel
branch
from
December 12, 2023 13:25
6085e34
to
b321ef9
Compare
jdeamicis
approved these changes
Dec 12, 2023
enrico-usai
added a commit
to enrico-usai/aws-parallelcluster-cookbook
that referenced
this pull request
Dec 14, 2023
This code has been created to try to install using `--releasever` parameter and if this command fails try to install the package from vault, anyway the `set -e` at the top of the failing was causing all the build to fail. Manually tested in a Rocky-8-EC2-Base-8.8-20230518.0.x86_64 Related to: aws#2598 Signed-off-by: Enrico Usai <[email protected]>
enrico-usai
added a commit
that referenced
this pull request
Dec 14, 2023
This code has been created to try to install using `--releasever` parameter and if this command fails try to install the package from vault, anyway the `set -e` at the top of the failing was causing all the build to fail. Manually tested in a Rocky-8-EC2-Base-8.8-20230518.0.x86_64 Related to: #2598 Signed-off-by: Enrico Usai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous releases are moved into a vault area once a new minor release version is available for at least a week. This means we cannot use
--releasever
to install 8.8 version because it is not more available in the repo.On RHEL8 instead all versions of the packages will remain available.
With this patch we're downloading this specific package from vault and installing it.
Tests
Manual execution of the new steps.
References